-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SYL-3329 Add support for Sylius 1.13 #287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mpysiak
commented
Mar 20, 2024
•
edited
Loading
edited
- Fix 1.13
- Update composer.json, add ecs check
- Limit builds
- Add support for node 20
- Add state machine config, add migrations for postgresql
Q | A |
---|---|
Branch? | 1.5 |
Bug fix? | no |
New feature? | no |
Related tickets |
This PR was merged into the 1.5 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | Related tickets | Sylius/Sylius#15582 Commits ------- [Composer] Remove Psalm [Psalm] Remove configuration file [Psalm] Remove outdated annotations
This PR was merged into the 1.5 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.5 | Bug fix? | yes | New feature? | no | Related tickets | replace Sylius#249 If the order already has a payment in the "new" status, then the Sylius orderPaymentProcessor must not be processed, otherwise a new payment in the "cart" status will be created, which will cause errors (2 payments in order ...). Before : ![image](https://user-images.githubusercontent.com/6593252/215053880-97319618-b24e-4a10-8281-15b71d494912.png) After : ![image](https://user-images.githubusercontent.com/6593252/215054517-63061d73-37d3-4644-b16c-f57867a7e7d0.png) Commits ------- e068f7c fix cancel payment
… version of `symfony/flex` to `^2.4` (Rafikooo) This PR was merged into the 1.5 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.5 | Bug fix? | yes | New feature? | no | Related tickets | Sylius/Sylius-Standard#945 Both changes were interdependent, so I propose to combine them into one PR to achieve the green build Commits ------- 7347d95 [Conflict] Add conflict with behat/mink-selenium2-driver:>=1.7.0 bea2505 [CI] Bump version of symfony/flex to ^2.4
Wojdylak
reviewed
Mar 26, 2024
mpysiak
force-pushed
the
fix/1.13
branch
3 times, most recently
from
March 26, 2024 11:22
4ed29ba
to
125bb0c
Compare
Wojdylak
reviewed
Apr 2, 2024
GSadee
reviewed
Apr 3, 2024
mpysiak
force-pushed
the
fix/1.13
branch
3 times, most recently
from
April 3, 2024 10:36
afd5785
to
f99bdad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of my comments will probably go away when you update the ecs config and rerun it, so start with that 👋
mpysiak
force-pushed
the
fix/1.13
branch
4 times, most recently
from
April 5, 2024 06:10
09ba67f
to
c378760
Compare
GSadee
approved these changes
Apr 8, 2024
Thank you, Michał! 🎉 |
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.